-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[WIP] Rough draft for chat index templates #125989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
...n/core/template-resources/src/main/resources/entsearch/connector/chat/comments-template.json
Show resolved
Hide resolved
...in/core/template-resources/src/main/resources/entsearch/connector/chat/support-template.json
Show resolved
Hide resolved
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
| } | ||
| } | ||
| }, | ||
| "content": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantic text for comment text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ comment content might be elaborate enough to be a good fit for semantic text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: semantic_text does not support nested fields, and this is not on our roadmap to support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kderusso what would be your suggestion on how to solve this today? copy_to a top-level field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I would need to verify if copy_to works with nested (I am not sure off the top of my head) but assuming it did, you'd lose the uniqueness that each comment text would have. I'm not sure if that's a deal breaker for search use cases - we would perform semantic search over all comments. It's worth digging into a bit more for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be very nice to be able to do a semantic query where I know I'd posted a message about ____ but can't remember the exact phrasing used, but don't want threads where other people were talking about ____. It's a real shame that we can't do nested semantic_text. :/
pgayvallet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template composition approach looks fine to me. This achieves the goal of having a common schema for all our content.
We're probably missing a bunch of obvious fields in that draft, leading to my main question: what would be our strategy regarding updating templates (e.g if we need to add new fields)?
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
...n/core/template-resources/src/main/resources/entsearch/connector/chat/comments-template.json
Show resolved
Hide resolved
...in/core/template-resources/src/main/resources/entsearch/connector/chat/support-template.json
Show resolved
Hide resolved
...in/core/template-resources/src/main/resources/entsearch/connector/chat/support-template.json
Show resolved
Hide resolved
...n/core/template-resources/src/main/resources/entsearch/connector/chat/comments-template.json
Show resolved
Hide resolved
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
...lugin/core/template-resources/src/main/resources/entsearch/connector/chat/base-template.json
Show resolved
Hide resolved
...n/core/template-resources/src/main/resources/entsearch/connector/chat/comments-template.json
Show resolved
Hide resolved
| "template": { | ||
| "mappings": { | ||
| "properties": { | ||
| "comments": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I conveniently skipped in the POC is attachments... comments can have attachments, for sure in sources like github and salesforce
Can we add minimal template for attachment, have a list of attachments in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good call. We probably need attachments as a top-level field, too.
...in/core/template-resources/src/main/resources/entsearch/connector/chat/support-template.json
Show resolved
Hide resolved
...in/core/template-resources/src/main/resources/entsearch/connector/chat/support-template.json
Show resolved
Hide resolved
|
Thanks all, for the great feedback. Stay tuned for the next round! |
DO NOT MERGE
This PR is intended for illustration purposes, and to solicit feedback on the composable schema capabilities.