Skip to content

Conversation

@seanstory
Copy link
Member

@seanstory seanstory commented Mar 31, 2025

DO NOT MERGE

This PR is intended for illustration purposes, and to solicit feedback on the composable schema capabilities.

@seanstory seanstory requested a review from a team March 31, 2025 19:35
}
}
},
"content": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic text for comment text?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ comment content might be elaborate enough to be a good fit for semantic text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: semantic_text does not support nested fields, and this is not on our roadmap to support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kderusso what would be your suggestion on how to solve this today? copy_to a top-level field?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. I would need to verify if copy_to works with nested (I am not sure off the top of my head) but assuming it did, you'd lose the uniqueness that each comment text would have. I'm not sure if that's a deal breaker for search use cases - we would perform semantic search over all comments. It's worth digging into a bit more for sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very nice to be able to do a semantic query where I know I'd posted a message about ____ but can't remember the exact phrasing used, but don't want threads where other people were talking about ____. It's a real shame that we can't do nested semantic_text. :/

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template composition approach looks fine to me. This achieves the goal of having a common schema for all our content.

We're probably missing a bunch of obvious fields in that draft, leading to my main question: what would be our strategy regarding updating templates (e.g if we need to add new fields)?

"template": {
"mappings": {
"properties": {
"comments": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I conveniently skipped in the POC is attachments... comments can have attachments, for sure in sources like github and salesforce

Can we add minimal template for attachment, have a list of attachments in the comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good call. We probably need attachments as a top-level field, too.

@seanstory
Copy link
Member Author

Thanks all, for the great feedback. Stay tuned for the next round!

@seanstory seanstory closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.